I have been a few times, I find it to be a photography wonderland, so much too shoot, a beautiful and fascinating place. The market in Marrakech is just amazing, but be aware that many people will want a small donation if you take their photo, while the money is small and not an issue, it can just get in the way the photo experience, leading to a lot of posed instead of candid photos. Also if you pay one person, you will more than likely pay many. I find this is one place it is better to be direct in taking your photos than try to sneak them. people are watching and may ask for money because they thought you to a photo of "the poor monkey in the toy car". I had a guy accuse us of photographing his cobra act because of they way my assistant was holding a camera low on the side of his leg, in the end no big deal, just smile. Highly recommend a drive through the Atlas mountains